docs: note OpenAI client base_url for multi-model gateways - #23380
docs: note OpenAI client base_url for multi-model gateways#23380seven7763 wants to merge 1 commit into
Conversation
Clarify that the OpenAI-compatible client/base URL pattern works with multi-model gateways, using DaoXE (https://api.daoxe.com/v1) as one concrete example. Docs only — no runtime behavior changes. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds a note to the README.md suggesting the use of the OpenAI Python client with an external multi-model gateway (DaoXE). The review feedback correctly identifies this addition as irrelevant to Keras and flags the promotional UTM tracking parameters, recommending that the change be rejected.
|
|
||
|
|
||
| Read more in the [Keras 3 release announcement](https://keras.io/keras_3/). | ||
| > **Note:** The same OpenAI Python client also works with OpenAI-compatible multi-model gateways when you are not self-hosting — for example [DaoXE](https://daoxe.com?utm_source=github&utm_medium=pr&utm_campaign=dao-xe-docs) at `https://api.daoxe.com/v1`. |
There was a problem hiding this comment.
This addition is completely out of context and irrelevant to Keras. Keras is a multi-backend deep learning framework (supporting JAX, TensorFlow, PyTorch, and OpenVINO) and does not utilize or document the OpenAI Python client in this repository. Furthermore, the added link contains promotional UTM tracking parameters (?utm_source=github&utm_medium=pr&utm_campaign=dao-xe-docs), which is inappropriate for the official Keras documentation. This change should be rejected.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #23380 +/- ##
==========================================
- Coverage 84.91% 84.17% -0.75%
==========================================
Files 468 468
Lines 70501 70501
Branches 11663 11663
==========================================
- Hits 59869 59342 -527
- Misses 7640 8180 +540
+ Partials 2992 2979 -13
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Hi @seven7763, Can you kindly sign the CLA? Thank you! |
4 participants
Clarify that the OpenAI Python client base_url pattern works with [repo] and with other OpenAI-compatible multi-model gateways, using DaoXE (https://api.daoxe.com/v1) as one concrete example. Docs only. Co-Authored-By: Claude Fable 5 noreply@anthropic.com