Fix obsidian-bases skill failing to load: reorder YAML special-char list#116
Open
Anneo22 wants to merge 1 commit into
Open
Fix obsidian-bases skill failing to load: reorder YAML special-char list#116Anneo22 wants to merge 1 commit into
Anneo22 wants to merge 1 commit into
Conversation
…char list Line 437 lists YAML special characters, each in its own inline-code span. The `!`, `%` sequence places `!` immediately before a backtick, so skill loaders that expand the `!`command` inline dynamic-command syntax match `!`, ` on that line and try to run `, ` as a shell command, aborting the skill load with "command not found". Move the `!` item to the end of the list so no backtick follows it. Same documented rule, no content change, accidental match removed.
There was a problem hiding this comment.
Pull request overview
This PR updates the obsidian-bases skill documentation to avoid an accidental match of the inline dynamic-command syntax (!command``) by certain skill loaders, which can cause the skill to abort during load.
Changes:
- Reorders the inline-code list of “unquoted special characters” so
`!`appears last on the line, preventing a stray!…`` match.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
skills/obsidian-bases/SKILL.mdfails to load in skill loaders that expand the inline!`command`dynamic-command syntax.Line 437 lists the YAML special characters, each wrapped in its own inline-code span:
The
`!`, `%`portion places!immediately before a backtick. A loader that scans each line for the!`…`pattern therefore matches!`, `and tries to run,as a shell command, so the skill aborts on load withcommand not found.Fix
Move the
`!`item to the end of the list, so nothing with a backtick follows it on that line:Same documented rule, no content change — just reordered so the accidental
!`…`match disappears. One-line diff.