Closed
Conversation
klboke
reviewed
Apr 15, 2026
| disabledownload: '${pdfDownloadDisable}', | ||
| disablebookmark: '${pdfBookmarkDisable}', | ||
| disableediting: '${pdfDisableEditing}', | ||
| pdfhighlightall: '${pdfhighlightAll}', |
Contributor
There was a problem hiding this comment.
这里变量名不对。控制器写入 model 的是 highlightall（OnlinePreviewController 第 85-87 行），仓库里没有 pdfhighlightAll 这个属性。现在传给 viewer 的 pdfhighlightall 会是空值，所以 viewer.mjs 里的高亮初始化分支仍然不会触发。
klboke
reviewed
Apr 15, 2026
| disableediting: '${pdfDisableEditing}', | ||
| pdfhighlightall: '${pdfhighlightAll}', | ||
| watermarktxt: '${watermarkTxt}', | ||
| pagemode: 'thumbs' // 缩略图模式 |
Contributor
There was a problem hiding this comment.
pagemode 这里被放进 query string 了，但 pdf.js 只会在 hash 里处理它。viewer.mjs 里的 setHash(...) 逻辑读取的是 #page=...&pagemode=thumbs；当前生成的是 ...?pagemode=thumbs#page=${page}，所以页码会生效，但左侧缩略图面板不会自动打开。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.