[Types] bracket accessors removed

common/configs/unit_restrictions_config.lua

@@ -20,7 +20,7 @@ for unitDefID, unitDef in pairs(UnitDefs) do
 		end
 	end
 
-	if (unitDef.minWaterDepth > 0 or unitDef.modCategories['ship']) and not (unitDef.customParams.restrictions_exclusion and string.find(unitDef.customParams.restrictions_exclusion, "_nosea_")) then
+	if (unitDef.minWaterDepth > 0 or unitDef.modCategories.ship ) and not (unitDef.customParams.restrictions_exclusion and string.find(unitDef.customParams.restrictions_exclusion, "_nosea_")) then
 		isWaterUnit[unitDefID] = true
 	end
 end

common/holidays.lua

@@ -77,49 +77,49 @@ local EasterEventDates = GetEasterStartEnd()
 
 local holidaysList = {
 	-- Static -----------------------------
-	["aprilfools"] = {
+	aprilfools = {
 		firstDay = { day = 1, month = 4},
 		lastDay = { day = 7, month = 4}
 	},
-    ["aprilfools_specialDay"] = {
+    aprilfools_specialDay = {
 		firstDay = { day = 1, month = 4},
 		lastDay = { day = 1, month = 4}
 	},
 
-	["halloween"] = {
+	halloween = {
 		firstDay = { day = 17, month = 10},
 		lastDay = { day = 31, month = 10}
 	},
-    ["halloween_specialDay"] = {
+    halloween_specialDay = {
 		firstDay = { day = 31, month = 10},
 		lastDay = { day = 31, month = 10}
 	},
 
-	["xmas"] = {
+	xmas = {
 		firstDay = { day = 12, month = 12},
 		lastDay = { day = 31, month = 12}
 	},
-    ["xmas_specialDay"] = {
+    xmas_specialDay = {
 		firstDay = { day = 24, month = 12},
 		lastDay = { day = 26, month = 12}
 	},
 
     -- We split these into two events because yes
-    ["newyearbefore"] = {
+    newyearbefore = {
 		firstDay = { day = 31, month = 12},
 		lastDay = { day = 31, month = 12}
 	},
-    ["newyearafter"] = {
+    newyearafter = {
 		firstDay = { day = 1, month = 1},
 		lastDay = { day = 1, month = 1}
 	},
 
 	-- Dynamic -----------------------------
-    ["easter"] = {
+    easter = {
 		firstDay = { day = EasterEventDates.firstDay, month = EasterEventDates.firstMonth},
 		lastDay = { day = EasterEventDates.lastDay, month = EasterEventDates.lastMonth}
 	},
-    ["easter_specialDay"] = {
+    easter_specialDay = {
 		firstDay = { day = EasterEventDates.easterDay, month = EasterEventDates.easterMonth},
 		lastDay = { day = EasterEventDates.easterDay, month = EasterEventDates.easterMonth}
 	},

common/lib_startpoint_guesser.lua

@@ -44,7 +44,7 @@ function GuessOne(teamID, allyID, xmin, zmin, xmax, zmax, startPointTable)
 	-- guess based on metal spots within startbox --
 
 	-- check if mex list generation worked and retrieve if so
-	local resourceSpotFinder = (GG and GG["resource_spot_finder"]) or (WG and WG["resource_spot_finder"])
+	local resourceSpotFinder = (GG and GG.resource_spot_finder ) or (WG and WG.resource_spot_finder )
 	local metalSpots = resourceSpotFinder and resourceSpotFinder.metalSpotsList or nil
 	if not metalSpots or #metalSpots == 0 then
 		return -1,-1

common/testing/mocha_json_reporter.lua

@@ -79,19 +79,19 @@ end
 
 function MochaJSONReporter:report(filePath)
 	local output = {
-		["stats"] = {
-			["suites"] = 1,
-			["tests"] = self.totalTests,
-			["passes"] = self.totalPasses,
-			["pending"] = 0,
-			["skipped"] = self.totalSkipped,
-			["failures"] = self.totalFailures,
-			["start"] = formatTimestamp(self.startTime),
+		stats = {
+			suites = 1,
+			tests = self.totalTests,
+			passes = self.totalPasses,
+			pending = 0,
+			skipped = self.totalSkipped,
+			failures = self.totalFailures,
+			start = formatTimestamp(self.startTime),
 			["end"] = formatTimestamp(self.endTime),
-			["duration"] = self.duration
+			duration = self.duration
 		},
-		["tests"] = self.tests,
-		["pending"] = self.skipped
+		tests = self.tests,
+		pending = self.skipped
 	}
 
 	local encoded = Json.encode(output)

common/upgets/api_resource_spot_finder.lua

@@ -30,11 +30,11 @@ local precision = Game.footprintScale * Game.squareSize -- (footprint 1 = 16 map
 
 -- Some of these maps have more than 2 metal spots, disable mex denier
 local metalMaps = {
-	["Oort_Cloud_V2"] = true,
+	Oort_Cloud_V2 = true,
 	["Asteroid_Mines_V2.1"] = true,
-	["Cloud9_V2"] = true,
-	["Iron_Isle_V1"] = true,
-	["Nine_Metal_Islands_V1"] = true,
+	Cloud9_V2 = true,
+	Iron_Isle_V1 = true,
+	Nine_Metal_Islands_V1 = true,
 	["SpeedMetal BAR V2"] = true,
 }
 local isMetalMap = false
@@ -384,14 +384,14 @@ function upget:Initialize()
 	end
 
 	geoSpots = GetSpotsGeo()
-	globalScope["resource_spot_finder"] = {}
-	globalScope["resource_spot_finder"].metalSpotsList = metalSpots
-	globalScope["resource_spot_finder"].geoSpotsList = geoSpots
-	globalScope["resource_spot_finder"].isMetalMap = isMetalMap
-	globalScope["resource_spot_finder"].GetClosestMexSpot = getClosestMex
-	globalScope["resource_spot_finder"].GetClosestGeoSpot = getClosestGeo
-	globalScope["resource_spot_finder"].GetBuildingPositions = GetBuildingPositions
-	globalScope["resource_spot_finder"].IsMexPositionValid = IsBuildingPositionValid
+	globalScope.resource_spot_finder = {}
+	globalScope.resource_spot_finder .metalSpotsList = metalSpots
+	globalScope.resource_spot_finder .geoSpotsList = geoSpots
+	globalScope.resource_spot_finder .isMetalMap = isMetalMap
+	globalScope.resource_spot_finder .GetClosestMexSpot = getClosestMex
+	globalScope.resource_spot_finder .GetClosestGeoSpot = getClosestGeo
+	globalScope.resource_spot_finder .GetBuildingPositions = GetBuildingPositions
+	globalScope.resource_spot_finder .IsMexPositionValid = IsBuildingPositionValid
 
 	if(gadget) then
 		setMexGameRules(metalSpots)

effects/antinuke.lua

@@ -6,7 +6,7 @@
 -- burngreen
 
 return {
-  ["antinuke"] = {
+  antinuke = {
     explosion = {
       air                = true,
       class              = [[CSimpleParticleSystem]],