Allow statsd reporting of instances of Num type class#3
Open
rewinfrey wants to merge 2 commits intokeithduncan:masterfrom
Open
Allow statsd reporting of instances of Num type class#3rewinfrey wants to merge 2 commits intokeithduncan:masterfrom
rewinfrey wants to merge 2 commits intokeithduncan:masterfrom
Conversation
added 2 commits
February 1, 2017 11:12
- Count could also be made generic over Num instances, but left it as is. - Statsd supports Num instances for the various types. - Motivating use case for this patch is wanting to send float values for a gauge metric.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch relaxes the
Inttype constraints ongaugeandhistogramreporting functions. As far as I can tell, there is no reason to confine these reporting metrics toInt, as statsd does not impose a type restriction on the value of those metrics.I've left
countandtimingunchanged, as those use cases seem to rely onIntandMillisecondrespectively, and it's not immediately clear what relaxing those type constraints might have on statsd operations.