This repository was archived by the owner on Nov 8, 2017. It is now read-only.
Skip keyCode check in is() when keyCode does not exist on event object#62
Open
brettpostin wants to merge 3 commits intokeithamus:masterfrom
Open
Skip keyCode check in is() when keyCode does not exist on event object#62brettpostin wants to merge 3 commits intokeithamus:masterfrom
brettpostin wants to merge 3 commits intokeithamus:masterfrom
Conversation
In some scenarios (e.g. Ctrl-Click) in Firefox and IE the event object does not have the keyCode property. Therefore the loop always returns false when comparing properties with the jwertycode object. This check skips the comparison if the property is missing on the event object.
Removed newline at end of file.
brettpostin
changed the title
Owner
|
Hey @brettpostin thanks for the PR! Could you explain what this solves, with code examples please? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In some scenarios (e.g. Ctrl-Click) in Firefox and IE the event object does not have the keyCode property. Therefore the loop always returns false when comparing properties with the jwertycode object.
This check skips the comparison if the property is missing on the event object.