Improve corrcoef performance with simpler reduction algorithm#74
Merged
Improve corrcoef performance with simpler reduction algorithm#74
Conversation
keichi
force-pushed
the
use-kokkos-math-functions
branch
from
269453f to
9b560c3
Compare
keichi
changed the title
keichi
force-pushed
the
use-kokkos-math-functions
branch
2 times, most recently
from
504aa42 to
b1ad0a7
Compare
…bility - Replace std::min/abs with Kokkos::min/abs in device code - Remove #ifndef KOKKOS_ENABLE_CUDA guards for using declarations
- Add CorrcoefSimpleState using sum-of-products instead of Welford's algorithm - Use CorrcoefSimpleState for both corrcoef functions (faster parallel reduction) - Remove unused volatile operator+= overload from CorrcoefState
keichi
force-pushed
the
use-kokkos-math-functions
branch
from
b1ad0a7 to
bd6eeb1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CorrcoefSimpleStateusing sum-of-products instead of Welford's algorithm for faster parallel reductionCorrcoefSimpleStatefor singlecorrcoef()calculation (improved performance)std::min/abs/sqrtwith Kokkos equivalents for CUDA compatibilityoperator+=overloadTest plan