Use LayoutRight for distances and indices in partial_sort#72
Merged
Conversation
- Add TmpIndices type with LayoutRight layout for GPU coalesced access - Modify partial_sort, full_sort, and full_sort_with_scratch to take TmpDistances and TmpIndices directly instead of SimplexLUT - Remove unnecessary deep_copy from TmpDistances to SimplexLUT in ccm() - Update ccm_test to use the new function signatures This improves GPU performance by ensuring coalesced memory access patterns in the j dimension during partial sorting operations.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TmpIndicestype with LayoutRight layout for GPU coalesced accesspartial_sort,full_sort, andfull_sort_with_scratchto takeTmpDistancesandTmpIndicesdirectly instead ofSimplexLUTdeep_copyfromTmpDistancestoSimplexLUTinccm()