feat!: Use semantic HTML <nav> element to wrap table of contents#614
Draft
kaushalmodi wants to merge 1 commit intomainfrom
Draft
feat!: Use semantic HTML <nav> element to wrap table of contents#614kaushalmodi wants to merge 1 commit intomainfrom
kaushalmodi wants to merge 1 commit intomainfrom
Conversation
There's a small chance that the user might need to tweak their site CSS for this change.
bmackinney
pushed a commit
to basa-casa/no-class
that referenced
this pull request
Nov 23, 2022
Do not yet use nav elements for TOC because of the issue shown in the screenshot in kaushalmodi/ox-hugo#614.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There's a small chance that the user might need to tweak their site
CSS for this change.
navelement. The TOC looks weird based on how some CSS libraries render thenavtags (see below). It's possible that that's the issue with that CSS library. But it would be good to not break rendering on any sites by leaving the TOC default element to the currently useddiv. Instead may be add a way to customize the TOC element.navelements with nestedul/lielements rendered bymvp.css