Use default ic_launcher as fallback - Android#543
Open
orcema wants to merge 1 commit intokatzer:masterfrom
Open
Use default ic_launcher as fallback - Android#543orcema wants to merge 1 commit intokatzer:masterfrom
orcema wants to merge 1 commit intokatzer:masterfrom
Conversation
Notification setup fails for background mode without any error triggered when 'resId' remains at value 0 due to missing valid icon ressource. This involves the notification to appear as "[application name] is running in background" and when you click on notification it opens the "App info" instad of the application itself. This fix makes the final icon fallback to be the launcher icon.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Notification setup fails for background mode without any error triggered when 'resId' remains at value 0 due to missing valid icon ressource.
This involves the notification to appear as "[application name] is running in background" and when you click on notification it opens the "App info" instad of the application itself.
This fix makes the final icon fallback to be the launcher icon.