Cross session dataleakage fix#71
Open
Tobiasee16 wants to merge 4 commits into
Open
Conversation
Problem: Any client knowing a chat_id (a UUID) could directly call get_drawn_layers(session_id=<victim_id>) and retrieve another user's map geometry. Fix: - Added mcp_auth.py. This makes it impossible for other users to call tool endpoints directly from the outside by generating a new token when the server starts. - All six entries in server.py are now wrapped with MCPAuthMiddleware - session:manager.py includes the token as a header in every MCP server registration so the Copilot SDK includes it automatically on outgoing ccalls.
- Add _ALLOWED_HOSTS frozenset; _fetch_json now rejects any URL whose scheme is not https or hostname is not ws.geonorge.no
Collaborator
sigurdbrekke
left a comment
sigurdbrekke
left a comment
There was a problem hiding this comment.
LGTM, men lurer på hvor og hva MCP_INTERNAL_SECRET er?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem:
Any client knowing a chat_id (a UUID) could directly call get_drawn_layers(session_id=<victim_id>) and retrieve another user's map geometry.
Fix:
@Tobiasee16
Tobiasee16 committed yesterday