Fix memory leak and segfault risk in DynamicVoronoi#65
Fix memory leak and segfault risk in DynamicVoronoi#65karlkurzer wants to merge 1 commit intomasterfrom
Conversation
This commit fixes a memory leak when `initializeMap` is called with a new map, as the existing `gridMap` was not being released. It also resolves a potentially fatal segmentation fault/invalid access bug in `initializeEmpty`, where old data arrays were incorrectly deallocated using the new map dimensions (if the map changed size) before they had actually been released. Fixes based on PR #62 but implemented robustly. Co-authored-by: karlkurzer <10877966+karlkurzer@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
Fixed memory leaks and segfault risk in
DynamicVoronoi::initializeMapandinitializeEmptywhen the map is dynamically updated with different sizes. Added a unit test to verify that memory is correctly cleaned up using Valgrind.PR created automatically by Jules for task 4983996835519819255 started by @karlkurzer