Updated ImageStack to be directionally aware#8
Open
paulcappadona wants to merge 1 commit intokaran413255:mainfrom
Open
Updated ImageStack to be directionally aware#8paulcappadona wants to merge 1 commit intokaran413255:mainfrom
paulcappadona wants to merge 1 commit intokaran413255:mainfrom
Conversation
Owner
|
@paulcappadona thanks for adding this functionality, I will check the PR and get back to you in couple of days |
ryanofreku
approved these changes
Jan 29, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ImageStack was using EdgeInsets when applying padding to the image placed in the Stack widget. This resulted in them being stacked one on top of the other for a locale that renders test from right to left (RTL - Arabic for instance).
Updated the padding to use EdgeInsetsDirectional, so this now renders correctly for both LTR and RTL layouts