refactor(proto): remove deprecated error field from AppendResult #1230
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit removes the deprecated `error` field from the `AppendResult` message in `proto/snpb/log_io.proto`. The field was originally deprecated in #985 as part of the transition to atomic append operations. With all usage of the field already removed, this commit completes the cleanup by deleting the field definition entirely.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## varlogsn_remove_legacy_storage_option_flags #1230 +/- ##
===============================================================================
- Coverage 79.79% 79.62% -0.17%
===============================================================================
Files 181 181
Lines 21891 21891
===============================================================================
- Hits 17467 17431 -36
- Misses 3638 3661 +23
- Partials 786 799 +13 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
This commit removes the deprecated
errorfield from theAppendResultmessagein
proto/snpb/log_io.proto.The field was originally deprecated in #985 as part of the transition to atomic
append operations. With all usage of the field already removed, this commit
completes the cleanup by deleting the field definition entirely.