Add shared fields and cases alias to @ObjectSource#186
Merged
Conversation
Closes #185 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
dosubot
bot
added
size:XS
- Add `tests` (alias for `value`) and `all` (shared fields) parameters to @ObjectSource annotation with empty string defaults for backward compatibility - Update ObjectSourceExtension to resolve test data from `tests.ifEmpty { value }` and merge `all` fields into every test case - Per-case fields override `all` fields via map concatenation - Add tests: tests alias, all merge, all+tests combined, override behavior, backward compatibility Closes #185 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
dosubot
bot
added
size:L
- Reject simultaneous use of `value` and `tests` parameters - Require at least `value` or `tests` to be provided - Use `ifBlank` instead of `ifEmpty` for consistent whitespace handling - Replace `assert()` with `assertTrue()` for better failure messages - Add test for `all` + `value` (positional) combination Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
Author
Review Round 1Issues Found & Fixed
ResultAll tests passing. No CRITICAL/HIGH issues remain. |
em3s
changed the title
all shared fields and tests alias to @ObjectSourceshared fields and cases alias to @ObjectSource
… → `cases` Clearer naming: `shared` conveys "shared across all cases", `cases` is more precise than "tests" for what the parameter actually holds. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
8 tasks
em3s
changed the title
shared fields and cases alias to @ObjectSourceshared fields and cases alias to @ObjectSource
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add
sharedandcasesparameters to@ObjectSourceannotation, enabling shared fields that merge into every test case. This keeps YAML self-contained and eliminates duplication of common setup data across test cases.Closes #185
Plan
sharedandcasesparameters toObjectSourceannotation (backward compatible)ObjectSourceExtensionprocessor: resolve test data fromcases.ifBlank { value }, parse and mergesharedfields into every test casecasesalias,sharedmerge,shared+casescombined, backward compatibilitytesting-guide.mdwithshared/casesusage examples (in root agent SSOT, not in this PR)