Add secret scanning and prevent credential leaks#1177
Conversation
9036f4f to
5ff52a9
Compare
|
Addressed both comments:
TruffleHog: It's the most widely used open-source secret scanner in the GitHub Actions ecosystem — used by GitLab, Postman, and many CNCF projects. Key reasons:
Alternatives considered: Happy to switch to another tool if the team prefers. |
5ff52a9 to
4ea1aee
Compare
4ea1aee to
2213cb0
Compare
- Add TruffleHog secret scanning to CI (PRs and pushes to master) - Add .gitignore entries for kubeconfig, PEM, key files, and .claude directory to prevent accidental commits of credentials A service account token was accidentally committed in #1166. This prevents that class of mistake going forward. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Aarno Aukia <aarno.aukia@vshn.ch>
2213cb0 to
eef88d0
Compare
Kidswiss
left a comment
There was a problem hiding this comment.
Should we also add a pre-commit-hook? If we scan after the push, the damage is already done, and Gtihub will still show you deleted commits.
Summary
Why
A service account token was accidentally committed in #1166 via a kubeconfig file in the working directory. This PR prevents that class of mistake:
*.kubeconfig,*.pem,*.key, and.claude/from being stagedTest plan
🤖 Generated with Claude Code