Add missing checksum check to install.sh#1653
Open
nkassis wants to merge 1 commit intok3d-io:mainfrom
Open
Conversation
install.sh references a checksum check but it's not implemented. This adds downloading the checksum file and checking the downloaded binary
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
install.sh references a checksum check but it's not implemented. This adds downloading the checksum file and checking the downloaded binary
Why
This ensure that users don't download any malicious binaries or corrupted files are used
Implications
This should not break any k3d functionality but will change the installer to do an additional check that requires the sha256sum or shasum (macosx) binaries to exists