Schedule requeue when updateStatus fails in K0sControlPlane defer#1368
Open
kahirokunn wants to merge 1 commit intok0sproject:mainfrom
Open
Schedule requeue when updateStatus fails in K0sControlPlane defer#1368kahirokunn wants to merge 1 commit intok0sproject:mainfrom
kahirokunn wants to merge 1 commit intok0sproject:mainfrom
Conversation
kahirokunn
force-pushed
the
fix/kcp-requeue-on-status-error
branch
from
b1873f6 to
5c312d2
Compare
Signed-off-by: kahirokunn <okinakahiro@gmail.com>
kahirokunn
force-pushed
the
fix/kcp-requeue-on-status-error
branch
from
5c312d2 to
d0398f6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When updateStatus fails, the defer returns early with the zero value of res, so controller-runtime does not schedule a retry. This can cause the controller to stall until an external event triggers reconciliation.