[jsk_robot_startup] Added commits not included in https://github.com/jsk-ros-pkg/jsk_robot/pull/1792 but included in https://github.com/jsk-ros-pkg/jsk_robot/pull/1883#102
Open
tkmtnt7000 wants to merge 10 commits intok-okada:ichikura_samplefrom
Conversation
Author: Naoto Tsukamoto <tsukamoto@jsk.imi.i.u-tokyo.ac.jp>
] Change nodelet name to adjust existing nodelet
k-okada
reviewed
Nov 1, 2023
k-okada
reviewed
Nov 1, 2023
k-okada
reviewed
Nov 1, 2023
| @@ -0,0 +1,26 @@ | |||
| <launch> | |||
Owner
There was a problem hiding this comment.
これはどこかからlaunch されている？であれば、以下のliflog は戻して arg & if かな。
Collaborator
Author
There was a problem hiding this comment.
これもarg & ifにします．
Collaborator
Author
There was a problem hiding this comment.
読み飛ばしていました．これはどこからも呼び出されてはいませんでした．
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
jsk-ros-pkg#1883
で追加して
jsk-ros-pkg#1792
に含まれていないコミットを追加しています．（コミットが汚いです．）