refactor: use linters in the env, fix mypy warns, improve makefiles#172
Merged
Merged
Conversation
fbad1e0 to
c2535db
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
refactor: use linters in the env, fix mypy warns, improve makefiles
Why the pull request was made
Actually, ruff and mypy are executed outside of the venv, causing some false alerts. It was necessary to patch that to have working linters/type checkers. They are now well implemented in the makefiles, and so, the makefiles are used anywhere we need to use linters/type checkers, or even run tests (so, we have one place to edit the way we run our checks/tests).
Summary of changes
pyproject.tomlwithruffandmypyuv runinstead ofuvxto run tools in our envScreenshots (if appropriate):
Not applicable.
How has this been tested?
Applied local tests, tested all makefiles targets (on debian 13/windows 11).
Resources
Not applicable.
Types of changes
Checklist