[DRAFT][DANGER] Reworked pyplot usage + formatting + code readability#2
Open
AlexanderButyaev wants to merge 3 commits into
Open
[DRAFT][DANGER] Reworked pyplot usage + formatting + code readability#2AlexanderButyaev wants to merge 3 commits into
AlexanderButyaev wants to merge 3 commits into
Conversation
…gg in thread +local RC context (vs global)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A lot of plot generation around the idea that pyplot should not be used directly - always create a figure, push it through renderer (FigureCanvasAgg), save it and later close/delete. When working with seaborn - add "thread safe"(ish) axis inside for it not to call plt stuff and mess up things.
In addition, removed block
as it could mix context with qtAGG backend (unlikely, but possible?)
!!! ATTENTION: PLOT_LOCK is missing in this version - add if works.
I had Black formatter on... sorry 🫤