Skip to content

fix(agent): eval awaits async expressions instead of returning the pending Promise (#177) #196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
justrach merged 1 commit into from
Aug 1, 2026
Merged

fix(agent): eval awaits async expressions instead of returning the pending Promise (#177) #196

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/agent_main.zig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -822,7 +822,10 @@ fn cmdViewport(arena: std.mem.Allocator, client: *CdpClient, args: []const []con

fn cmdEval(arena: std.mem.Allocator, client: *CdpClient, expr: []const u8) !void {
const escaped = try escapeForJson(arena, expr);
const params = try std.fmt.allocPrint(arena, "{{\"expression\":\"{s}\",\"returnByValue\":true}}", .{escaped});
// #177: without awaitPromise an async expression returns the pending
// Promise object (value lost); with it, CDP resolves first — same flag the
// HTTP /evaluate route and cmdHeaders/cmdAudit already pass.
const params = try std.fmt.allocPrint(arena, "{{\"expression\":\"{s}\",\"returnByValue\":true,\"awaitPromise\":true}}", .{escaped});
const response = client.send(arena, protocol.Methods.runtime_evaluate, params) catch |err| {
jsonError("eval failed: {s}", .{@errorName(err)});
std.process.exit(1);
Expand Down
Loading