Skip to content

feat(pie-cookie-banner): DSW-3787 add cookie banner Canada locale - #2737

Merged
cacuba merged 12 commits into
mainfrom
DSW-3787-ca-locale-cookie-banner
Mar 31, 2026
Merged

feat(pie-cookie-banner): DSW-3787 add cookie banner Canada locale#2737
cacuba merged 12 commits into
mainfrom
DSW-3787-ca-locale-cookie-banner

Conversation

@cacuba

@cacuba cacuba commented Mar 27, 2026

Copy link
Copy Markdown
Contributor

Describe your changes

Added locale files for Canada to support cookie banner regional content.
Wired the new locale resources into the existing cookie-banner localisation flow.
Ensured naming and structure are consistent with existing locale conventions used by pie-cookie-banner.

Author Checklist

  • I have performed a self-review of my code.
  • I have added thorough tests where applicable (unit / component / visual).
  • I have reviewed the PIE Storybook/PIE Docs PR preview.
  • I have reviewed visual test updates properly before approving.
  • If changes will affect consumers of the package, I have created a changeset entry.
  • If a changeset file has been created, I have tested these changes in PIE Aperture using the /test-aperture command.
  • I have filled out the DS Review Tracker checklist (Moving PR to "Ready to Review")

Not-applicable Checklist items

N/A


Testing

Ran targeted checks for pie-cookie-banner locale loading and fallback behaviour.
Confirmed existing locales continue to resolve correctly.
Confirmed Canada locale content is available and rendered when locale is set to CA.

Task Link
Aperture PR 🔗
NextJS 15 deployment 🔗
NextJS 14 deployment 🔗
Nuxt 3 deployment 🔗
Vanilla deployment 🔗

Reviewer checklists (complete before approving)

N/A

Reviewer 1 - @jamieomaguire

  • I have reviewed the PIE Storybook/PIE Docs PR preview.
  • I have verified that all acceptance criteria for this ticket have been completed.
  • I have reviewed the Aperture changes (if added)
  • If there are visual test updates, I have reviewed them.

Reviewer 2

  • I have reviewed the PIE Storybook/PIE Docs PR preview.
  • I have verified that all acceptance criteria for this ticket have been completed.
  • I have reviewed the Aperture changes (if added)
  • If there are visual test updates, I have reviewed them.

@cacuba

cacuba commented Mar 27, 2026

Copy link
Copy Markdown
Contributor Author

/test-aperture

@pie-design-system-bot

Copy link
Copy Markdown
Contributor

Starting a new snapshot build. You can view the logs here.

@pie-design-system-bot

Copy link
Copy Markdown
Contributor

@cacuba Your snapshots have been published to npm!

Test the snapshots by updating your package.json with the newly-published versions:

Note

If you have more than one of these packages installed, we suggest using the new snapshots for all of them to help avoid version conflicts.

yarn up @justeattakeaway/pie-cookie-banner@0.0.0-snapshot-release-20260327143923 --mode=update-lockfile
yarn up @justeattakeaway/pie-webc@0.0.0-snapshot-release-20260327143923 --mode=update-lockfile
yarn up @justeattakeaway/eslint-plugin-snacks-pie-migration@0.0.0-snapshot-release-20260327143923 --mode=update-lockfile

Then finally:

yarn install

@changeset-bot

changeset-bot Bot commented Mar 31, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 939faee

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
@justeattakeaway/eslint-plugin-snacks-pie-migration Patch
@justeattakeaway/pie-cookie-banner Patch
@justeattakeaway/pie-webc Patch
@justeattakeaway/pie-docs Patch
@justeattakeaway/pie-storybook Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@cacuba
cacuba merged commit 5ba9647 into main Mar 31, 2026
28 of 29 checks passed
@cacuba
cacuba deleted the DSW-3787-ca-locale-cookie-banner branch March 31, 2026 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants