Skip to content

Fix werkzeug cannot import name 'safe_str_cmp' & circular imports#30

Open
5t33 wants to merge 3 commits intojuriansluiman:masterfrom
5t33:master
Open

Fix werkzeug cannot import name 'safe_str_cmp' & circular imports#30
5t33 wants to merge 3 commits intojuriansluiman:masterfrom
5t33:master

Conversation

@5t33
Copy link

@5t33 5t33 commented Sep 4, 2022

  • Updated several dependencies to fix safe_str_cmp werkzeug issue
  • refactor to use flask blueprint to fix circular dependency issue
  • add .vscode to .gitignore

related Issues:
#29
#28
#19

5t33 added 2 commits September 3, 2022 19:23
- refactor to use flask bluebird to fix circular dependency issue
- add .vscode to .gitignore
@5t33 5t33 changed the title Fix werkzeug cannot import name 'safe_str_cmp' & circular imports (WIP) Fix werkzeug cannot import name 'safe_str_cmp' & circular imports Sep 4, 2022
function profile() {
let form = document.getElementById('profile-form')
form.addEventListener('submit', function(event) {
let uri = '{{ url_for('profile') }}'
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was causing the settings page to error-out completely. I see that there was already an issue with the settings page, which I'm guessing is because there isn't a profile page or a profile.html template. So, I'm thinking the best path forward is to create the page or template?

<td></td>
<td>
<a class="ui labeled icon button" href="{{ url_for('recipes', schedule='24-3-2020') }}">
<a class="ui labeled icon button" href="{{ url_for('main.recipes', schedule='24-3-2020') }}">
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@5t33
Copy link
Author

5t33 commented Sep 4, 2022

Still QAing this. Doesn't look like I'm able to add a pantry section.

Edit - that seems to be expected. That part looks unfinished.

@5t33 5t33 changed the title (WIP) Fix werkzeug cannot import name 'safe_str_cmp' & circular imports Fix werkzeug cannot import name 'safe_str_cmp' & circular imports Sep 4, 2022
@5t33
Copy link
Author

5t33 commented Sep 4, 2022

This should be good to go. I was able to create a new recipe successfully. LMK what you think, @juriansluiman. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant