Move the check_release.yml to its own workflow#2191
Open
jtpio wants to merge 5 commits intojupyter:mainfrom
Open
Move the check_release.yml to its own workflow#2191jtpio wants to merge 5 commits intojupyter:mainfrom
check_release.yml to its own workflow#2191jtpio wants to merge 5 commits intojupyter:mainfrom
Conversation
check_release.yml to its own workflow
Member
Author
|
@martinRenou I was wondering if this was maybe ready to be merged? Having the built artifacts could help test changes from other PRs more easily, for example #2178. |
Member
|
nbconvert/.github/workflows/tests.yml Lines 161 to 170 in 6e5fdb3 It would need to be removed from it and added as a separate protection rule |
auto-merge was automatically disabled
January 2, 2025 17:41
Head branch was pushed to by a user without write access
Member
Author
Done in 5541bdb. However I don't have access to the repo settings to enable the protection rule in case we want to add one (not sure if this may have an impact on the releaser though). |
for more information, see https://pre-commit.ci
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
check_releasestep to a separate workflow, so it's easier to see if it passes