Add more RISE config options to SlidesExporter#2147
Open
lkeegan wants to merge 1 commit intojupyter:mainfrom
Open
Add more RISE config options to SlidesExporter#2147lkeegan wants to merge 1 commit intojupyter:mainfrom
lkeegan wants to merge 1 commit intojupyter:mainfrom
Conversation
- reveal_overlay - reveal_header - reveal_backimage - reveal_footer These options are documented here: https://rise.readthedocs.io/en/latest/customize.html#decorating-all-slides Styling and ids of these elements follow RISE: https://github.com/damianavila/RISE/blob/master/classic/rise/static/main.js#L446-L470 Also update the reveal config options using the reveal dict in the notebook metadata if provided.
lkeegan
force-pushed
the
add_rise_overlay_header_footer_backimage_config_options
branch
from
24fb9ad to
f1db586
Compare
Contributor
Author
|
Example of use:
|
Contributor
I happened across this PR after submitting my own that does the above. I checked your code and I think you are missing logic that copies the metadata options into the reveal initialization function. Otherwise, anything that isn't already configurable (command line and config file) wont be added. My related PR: #2257 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These options are documented here: https://rise.readthedocs.io/en/latest/customize.html#decorating-all-slides
Styling and ids of these elements follow RISE: https://github.com/damianavila/RISE/blob/master/classic/rise/static/main.js#L446-L470
Also update the reveal config options using the reveal dict in the notebook metadata if provided.