Fix ESLint v10 RuleContext API removal (follow-up to #3972)#3979
Open
ledsun wants to merge 12 commits intojsx-eslint:masterfrom
Open
Fix ESLint v10 RuleContext API removal (follow-up to #3972)#3979ledsun wants to merge 12 commits intojsx-eslint:masterfrom
ledsun wants to merge 12 commits intojsx-eslint:masterfrom
Conversation
ljharb
reviewed
Feb 10, 2026
Member
ljharb
left a comment
ljharb
left a comment
There was a problem hiding this comment.
we'll need regression tests - it might be as simple as adding eslint 10 to the GHA matrix.
sergeyklay
added a commit
to sergeyklay/oar
that referenced
this pull request
Feb 10, 2026
sergeyklay
added a commit
to sergeyklay/oar
that referenced
this pull request
Feb 10, 2026
6 tasks
ledsun
force-pushed
the
update-deprecated-calls-v8
branch
from
f987ffa to
a7b967b
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3979 +/- ##
==========================================
- Coverage 97.85% 97.81% -0.04%
==========================================
Files 136 136
Lines 10008 10013 +5
Branches 3717 3718 +1
==========================================
+ Hits 9793 9794 +1
- Misses 215 219 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Run published type checks against both ESLint 7 and 10. Use per-matrix dependency setup and exclude unsupported TS combinations for ESLint 10.
- route filename/sourceCode access through util helpers for ESLint 7/10 compatibility - remove deprecated meta.docs.category to satisfy current RuleModule typings - augment @eslint/core SettingsConfig with react settings shape
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Co-authored-by: Dom Armstrong <dom@dom-armstrong.co.uk>
ljharb
reviewed
Feb 12, 2026
ljharb
requested changes
Feb 13, 2026
| matrix: | ||
| node-version: ${{ fromJson(needs.matrix.outputs.latest) }} | ||
| eslint: | ||
| - 10 |
Member
There was a problem hiding this comment.
you'll also need to exclude eslint 10 on node < 20
| const resolve = require('resolve'); | ||
| const semver = require('semver'); | ||
| const error = require('./error'); | ||
| const eslintUtil = require('./eslint'); |
Member
There was a problem hiding this comment.
Suggested change
| const eslintUtil = require('./eslint'); | |
| const getFilename = require('./eslint').getFilename; |
| "@typescript-eslint/parser": "^2.34.0 || ^3.10.1 || ^4 || ^5 || ^6.20 || ^7.14.1 || 8.4 - 8.17", | ||
| "babel-eslint": "^8 || ^9 || ^10.1.0", | ||
| "eslint": "^3 || ^4 || ^5 || ^6 || ^7 || ^8 || ^9.7", | ||
| "eslint": "^3 || ^4 || ^5 || ^6 || ^7 || ^8 || ^9.7 || ^10.0", |
Member
There was a problem hiding this comment.
this might be premature; it's fine if the eslint 10 tests don't completely pass after this PR, and this line is what actually adds support for it.
however obv if this PR is sufficient to support eslint 10, this is great :-)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR follows up on the feedback in the comments of #3972 and incorporates the requested changes.
I think this PR will fix #3977.