Skip to content

Conversation

@beaverden
Copy link

@beaverden beaverden commented Jun 9, 2021

I submitted the first draft of running the library though docker, although I'm not sure if it's the right way. Technically, the library is not dockerized and it's just a container that installs the library through npm.

Probably a better solution would be to dockerize the library itself and provide the image on docker hub, such that different commands can be ran. With that being said, I can't say that I'm experienced in dockerizing npm packages

@beaverden beaverden changed the title docs(README.md) added example Dockerfile and instructions to run inside docker docs(README.md): added example Dockerfile and instructions to run inside docker Jun 9, 2021
@beaverden
Copy link
Author

It seems like there already are docker images for jsonresume (like https://hub.docker.com/r/svendowideit/jsonresume/ - https://github.com/SvenDowideit/dockerfiles/blob/master/jsonresume/Dockerfile)

Which do a much better job at being able to run generic commands

@beaverden beaverden closed this Jun 9, 2021
@thomasdavis
Copy link
Member

@beaverden Thanks for that, are you saying the pre-existing docker setups solve your initial problem?

@beaverden
Copy link
Author

I realized that the purpose of the fix was to specify how to run the library when chromium doesn't install properly using puppeteer and npm, not to add a (somehow) working dockerfile (of which there already are plenty). See #599 for a lighter fix that just adds some info to the README

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants