[jsk_robot_startup] Support embed image in email_topic.py#1485
[jsk_robot_startup] Support embed image in email_topic.py#1485k-okada merged 5 commits intojsk-ros-pkg:masterfrom
Conversation
|
Superb! |
Sorry, I mistakenly write an example code. Updated. |
|
Thank you for this cool feature! I also checked that content_1 = EmailBody()
content_1.type = 'html'
content_1.message = '<p><font size="7" color="#00ff00">サイズが7で緑色</font></p>\n'One thing. |
Sorry, |
26eba36 to
9cd94a0
Compare
|
Thank you for comments. content = EmailBody()
content.type = 'img'
content.file_path = '/home/tsukamoto/Pictures/fetch-door4.png'
content.img_size = 50 Now, we have to write |
k-okada
left a comment
There was a problem hiding this comment.
nice!!
I am OK with this. just to confirm no one will spend time, just to move this code to another in future...
|
the release is a good point of jsk_common, hmm. |
|
I understand your thoughts, specially I found |
|
So... should I move |
I agree. |
|
|
|
Sorry, I understood mistakenly. |
There was a problem hiding this comment.
Arguably it would also be nice to have an option to send an image directly from the client, instead of needing a local path in the robot PC. (I and Kochigami are working on a similar case for Pepper's tablet, thinking of further usage with scratch)
The message could be encoded as base64 or any other ros-compliant data type.
e.g.
[app_manager/Icon]:
string format
uint8[] data
We should evaluate if this is safe or not first, though.
|
When I was writing a node that sends an email with an image depending on the state of smach, I realized that it would be nice to receive the image topic( |
This PR supports sending embed image with email_topic.py. (Discussion in #1463)
TODO