perf: Always return arrays from parsePropertyValue#290
Merged
Conversation
The inArray parameter caused cache thrashing: CSSStyleDeclaration.js called without it (caching strings) while property files called with inArray: true (expecting arrays). When the cached type didn't match what a caller needed, it would recompute and overwrite, causing the next different-type caller to also miss. By always returning arrays, all callers can share the same cached results. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
3 tasks
asamuzaK
reviewed
Jan 9, 2026
| const value = parsers.parsePropertyValue(property, val, { | ||
| globalObject, | ||
| inArray: true | ||
| globalObject |
Contributor
There was a problem hiding this comment.
We can remove all { globalObject }, not just this file.
See #280 (comment)
Member
Author
There was a problem hiding this comment.
Yeah, I was thinking of including that in this PR but it's simpler to just focus this PR on isArray.
Contributor
|
LGTM |
Member
Author
Without changesWith changesNot a huge improvement but since it makes the code simpler anyway, let's merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The inArray parameter caused cache thrashing: CSSStyleDeclaration.js
called without it (caching strings) while property files called with
inArray: true (expecting arrays). When the cached type didn't match
what a caller needed, it would recompute and overwrite, causing the
next different-type caller to also miss. By always returning arrays,
all callers can share the same cached results.
🤖 Generated with Claude Code
To-do before merging: