perf: Add property-to-index Map for O(1) lookups in _getIndexOf#288
Closed
perf: Add property-to-index Map for O(1) lookups in _getIndexOf#288
Conversation
Replaces the O(n) linear search in _getIndexOf with an O(1) Map lookup. The _propertyIndices Map is maintained alongside the indexed properties to track each property's position. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
asamuzaK
added a commit
to asamuzaK/cssstyle
that referenced
this pull request
Jan 9, 2026
Contributor
|
Wouldn't it be better to separate the functions as originally used, rather than repeating the for loop multiple times? |
asamuzaK
added a commit
to asamuzaK/cssstyle
that referenced
this pull request
Jan 9, 2026
asamuzaK
added a commit
to asamuzaK/cssstyle
that referenced
this pull request
Jan 9, 2026
Member
Author
|
Agreed, #291 is better; will close this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces the O(n) linear search in _getIndexOf with an O(1) Map lookup. The _propertyIndices Map is maintained alongside the indexed properties to track each property's position.
🤖 Generated with Claude Code
To-do before merging: