If the function returns a future, handle things asynchronously#12
Open
spanezz wants to merge 3 commits intojoshmarshall:masterfrom
Open
If the function returns a future, handle things asynchronously#12spanezz wants to merge 3 commits intojoshmarshall:masterfrom
spanezz wants to merge 3 commits intojoshmarshall:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently I can use @async to make a xmlrpc server method asynchronous, but with tornado.gen and friends, I tried to make it so that I could use a @gen.coroutine instead. The first step was to make it so that if an xmlrpc method returns a Future, it is run asynchronously and its result is returned transparently.
Unfortunately, @gen.coroutines still cannot be used transparently, because the wrapper that they create confuses tornadorpc's getcallargs. Still, I find this change quite handy.
With regards to using gen.coroutines, at least now I can do this: