Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #12 +/- ##
============================================
+ Coverage 95.74% 95.84% +0.10%
+ Complexity 335 316 -19
============================================
Files 26 26
Lines 1081 1035 -46
============================================
- Hits 1035 992 -43
+ Misses 46 43 -3 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Pull request overview
This PR refactors the compiled cache serialization from custom var_export logic to use the brick/varexporter library, enabling support for arbitrary objects without requiring __set_state implementation.
Key changes:
- Adds brick/varexporter dependency to handle more flexible object serialization
- Removes ~110 lines of custom export code (exportString, exportValue, exportArray methods)
- Updates tests to verify objects without __set_state can now be cached successfully
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| composer.json | Adds brick/varexporter ^0.7.0 dependency |
| src/Service/CompiledCache.php | Replaces custom export methods with VarExporter::export() calls, removes UnitEnum import |
| tests/TestCase/Service/CompiledCacheTest.php | Updates test to verify objects without __set_state can be cached and properly round-trip |
| README.md | Updates documentation to reflect new object serialization capabilities without __set_state requirement |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.