[7.0] Moves deprecated HTML helpers to compat#47974
Open
laoneo wants to merge 4 commits into
Open
Conversation
laoneo
added
the
b/c break
laoneo
changed the title
dgrammatiko
reviewed
Jun 20, 2026
| HTMLHelper::_('bootstrap.framework'); | ||
| Factory::getApplication()->getDocument()->getWebAssetManager()->useScript('dropdown'); | ||
|
|
||
| Factory::getDocument()->addScriptDeclaration(" |
Contributor
There was a problem hiding this comment.
@laoneo you do realize that this is completely broken, ie the inline script is using jQuery without actually including it...
Contributor
There was a problem hiding this comment.
No need for a fix, just pointing out that this file was probably unusable for quite some time ie since 4.0 😀
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Moves deprecated HTML helper functions to the compat plugin. When the whole helper is not deprecated, then the respective functions will throw an exception when the plugin is disabled.
Testing Instructions
\Joomla\CMS\HTML\HTMLHelper::_('behavior.core');to the file /components/com_content/tmpl/featured/default.phpActual result BEFORE applying this Pull Request
It always loads.
Expected result AFTER applying this Pull Request
It loads with the compat plugin enabled and throws the following error when disabled:
behavior::core not found
Link to documentations
Please select:
Documentation link for guide.joomla.org:
No documentation changes for guide.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed