[5.4] Use the correct function to get the message from an exception#47972
Open
laoneo wants to merge 1 commit into
Open
[5.4] Use the correct function to get the message from an exception#47972laoneo wants to merge 1 commit into
laoneo wants to merge 1 commit into
Conversation
richard67
approved these changes
Jun 19, 2026
richard67
left a comment
Member
There was a problem hiding this comment.
The change is correct according to https://www.php.net/manual/en/class.exception.php .
There is no errorMessage() for the exception object, there is getMessage().
Contributor
|
I have tested this item ✅ successfully on 1588657 throw new \RuntimeException('test'); //after line 203 Note the backslash before \RuntimeException This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/47972. |
Member
|
I have tested this item ✅ successfully on 1588657 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/47972. |
Member
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/47972. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
The exception object doesn't have an
errorMessagefunction,getMessageshould be used instead.Testing Instructions
throw new RuntimeException('test');Actual result BEFORE applying this Pull Request
The following error is shown:
Call to undefined method RuntimeException::errorMessage()
Expected result AFTER applying this Pull Request
A warning message appears with text 'test'.
Link to documentations
Please select:
Documentation link for guide.joomla.org:
No documentation changes for guide.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed