[5.4] Show readmore in mod_articles when introtext_limit truncates text#47966
[5.4] Show readmore in mod_articles when introtext_limit truncates text#47966rish106-hub wants to merge 1 commit into
Conversation
|
There is already a PR for the same issue: #47713 . |
|
@richard67 Thanks for flagging #47713. Our approach differs in a key way: #47713 has an open review comment from @QuyTon noting the fix executes even when In this PR, Happy to close if maintainers prefer to update #47713 instead. |
|
I have tested this item ✅ successfully on 5621400 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/47966. |
|
@richard67 — adding to my earlier response: @krishnagandhicode has independently tested and confirmed this PR works correctly on 5621400. To summarise why this PR addresses the regression more completely than #47713:
With a passing test and CI green, happy to have this reviewed for merge or to close in favour of a corrected #47713 - whichever the team prefers. |
Pull Request resolves #47710.
Summary of Changes
PR #47263 fixed readmore showing when there is nothing to read, but introduced a regression: when
introtext_limitis used to truncate text (instead of a readmore marker),$item->fulltextis empty so the readmore button never renders even though the article IS truncated and there IS more to read.Fix tracks whether truncation actually occurred and uses that flag alongside
$item->fulltextto decide readmore visibility.Testing Instructions
Actual result BEFORE applying this PR
No readmore button shown even though text is truncated by introtext_limit
Expected result AFTER applying this PR
Readmore button appears when introtext is truncated. Does not appear when text fits within limit. Articles using readmore marker unaffected.