Skip to content

[5.4] Always use a new installer instance on discover install#47964

Merged
richard67 merged 6 commits into
joomla:5.4-devfrom
Digital-Peak:cli/discover
Jun 19, 2026
Merged

[5.4] Always use a new installer instance on discover install#47964
richard67 merged 6 commits into
joomla:5.4-devfrom
Digital-Peak:cli/discover

Conversation

@laoneo

@laoneo laoneo commented Jun 15, 2026

Copy link
Copy Markdown
Member

Pull Request resolves #47948.

  • I read the Generative AI policy and my contribution is either not created with the help of AI or is compatible with the policy and GNU/GPL 2 or later.

Summary of Changes

This pr reverts the change from #47637 as it caused issues when installing a package with the web interface. Instead of it moves the installer instantiation out of the loop in the cli console command. Like that no old settings are used from the previous installed extension, when installing multiple at once.

Testing Instructions

  • Extract the file plg_system_test1.zip into the folder /plugins/system/test1
  • Extract the file plg_system_test2.zip into the folder /plugins/system/test2
  • Discover install the extensions on the command line with the commands:
    /cli/joomla.php extension:discover
    /cli/joomla.php extension:discover:install

Actual result BEFORE applying this Pull Request

The following info text is displayed:
Postflight executed for test 1

Expected result AFTER applying this Pull Request

The following info text is displayed:
Postflight executed for test 1
Postflight executed for test 2

Link to documentations

Please select:

  • Documentation link for guide.joomla.org:

  • No documentation changes for guide.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@laoneo laoneo requested a review from rdeutz as a code owner June 15, 2026 15:23
Comment thread libraries/src/Console/ExtensionDiscoverInstallCommand.php
@joomdonation

Copy link
Copy Markdown
Contributor

I have tested this item ✅ successfully on 04fbff3

Both issues are sorted

Comment thread libraries/src/Console/ExtensionDiscoverInstallCommand.php Outdated
@richard67

Copy link
Copy Markdown
Member

@joomdonation Could you test again with the latest changes? Thanks in advance.

@roland-d

Copy link
Copy Markdown
Contributor

I have tested this item ✅ successfully on 5185894

So I have tested the changes and they work as expected. Before applying the patch my script.php was not found and thus not executed. After applying the patch my script.php is found and properly executed.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/47964.

@joomdonation

Copy link
Copy Markdown
Contributor

I have tested this item ✅ successfully on 5185894


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/47964.

@joomla-cms-bot joomla-cms-bot removed this from the Joomla! 5.4.7 milestone Jun 17, 2026
@joomdonation

Copy link
Copy Markdown
Contributor

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/47964.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jun 17, 2026
@richard67 richard67 added this to the Joomla! 5.4.7 milestone Jun 17, 2026
@richard67 richard67 merged commit 1d2f919 into joomla:5.4-dev Jun 19, 2026
70 checks passed
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Jun 19, 2026
@richard67

Copy link
Copy Markdown
Member

Thanks @laoneo for this PR, @roland-d and @joomdonation for testing, and @QuyTon for review.

@laoneo laoneo deleted the cli/discover branch June 19, 2026 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Install Script for components/packages not executed anymore

6 participants