[5.4] Always use a new installer instance on discover install#47964
Merged
Conversation
Contributor
|
I have tested this item ✅ successfully on 04fbff3
|
QuyTon
reviewed
Jun 15, 2026
Member
|
@joomdonation Could you test again with the latest changes? Thanks in advance. |
Contributor
|
I have tested this item ✅ successfully on 5185894 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/47964. |
Contributor
|
I have tested this item ✅ successfully on 5185894 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/47964. |
Contributor
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/47964. |
Member
|
Thanks @laoneo for this PR, @roland-d and @joomdonation for testing, and @QuyTon for review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request resolves #47948.
Summary of Changes
This pr reverts the change from #47637 as it caused issues when installing a package with the web interface. Instead of it moves the installer instantiation out of the loop in the cli console command. Like that no old settings are used from the previous installed extension, when installing multiple at once.
Testing Instructions
/cli/joomla.php extension:discover/cli/joomla.php extension:discover:installActual result BEFORE applying this Pull Request
The following info text is displayed:
Postflight executed for test 1
Expected result AFTER applying this Pull Request
The following info text is displayed:
Postflight executed for test 1
Postflight executed for test 2
Link to documentations
Please select:
Documentation link for guide.joomla.org:
No documentation changes for guide.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed