Skip to content

[6.2] Remove cache deprecated code in banner model#47958

Merged
laoneo merged 2 commits into
joomla:6.2-devfrom
joomdonation:remove_cache_deprecated_code_in_BannerModel
Jun 18, 2026
Merged

[6.2] Remove cache deprecated code in banner model#47958
laoneo merged 2 commits into
joomla:6.2-devfrom
joomdonation:remove_cache_deprecated_code_in_BannerModel

Conversation

@joomdonation

Copy link
Copy Markdown
Contributor

Pull Request resolves # .

  • I read the Generative AI policy and my contribution is either not created with the help of AI or is compatible with the policy and GNU/GPL 2 or later.

Summary of Changes

The BannerModel still uses deprecated method Factory::getCache to create cache controller. This PR updates code to use the injected cache controller factory to create cache controller instead.

Testing Instructions

  • Use Joomla 6.2
  • Go to System -> Global Configuration, System tab, set System Cache to one of the two ON options
  • Create one or two banners if no banners created before
  • Create an instance of Banners module, publish it in a module position in frontend of your site
  • Visit frontend of your site, see the module, click on the banner
  • Make sure you still being redirected to the URL associated with the banner

Actual result BEFORE applying this Pull Request

Works, but uses deprecated code

Expected result AFTER applying this Pull Request

Works, without using deprecated code

Link to documentations

Please select:

  • Documentation link for guide.joomla.org:

  • No documentation changes for guide.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@laoneo laoneo added the Architecture Pull requests which improve the architecture. label Jun 18, 2026
@laoneo laoneo merged commit 21e812b into joomla:6.2-dev Jun 18, 2026
2 checks passed
@laoneo laoneo added this to the Joomla! 6.2.0 milestone Jun 18, 2026
@laoneo

laoneo commented Jun 18, 2026

Copy link
Copy Markdown
Member

Thanks!

@joomdonation joomdonation deleted the remove_cache_deprecated_code_in_BannerModel branch June 18, 2026 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Architecture Pull requests which improve the architecture. PR-6.2-dev

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants