[5.4] Github Actions: Automatic PHP codestyle fixes for PRs#46874
Closed
Hackwar wants to merge 41 commits into
Closed
[5.4] Github Actions: Automatic PHP codestyle fixes for PRs#46874Hackwar wants to merge 41 commits into
Hackwar wants to merge 41 commits into
Conversation
* Add phpstan to github action * Update ci.yml * Update ci.yml
richard67
changed the title
Member
|
@Hackwar As this PR handles only PHP code style, I've allowed myself to add that to the title and description. |
Member
|
@Hackwar What happens if both PHP code style checkers find some issue at the same place and both make suggestions? Will that work? And how about JS and CSS code style fixes? Could those be handled, too, with a GitHub action (ans possibly new corresponding commands in our package.json)? |
Member
|
Other question. The CI workflow runs on both push and pull_request events. Could this be an issue, and we should create code style suggestions only on pull_request but not on push? |
5 tasks
Member
Author
|
Closing this one for #47914 |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
This PR implements automatic PHP codestyle fixes to pull requests. When a PR does not have the right codestyle, this will create suggestions to fix it.
This is an updated remake of #45652