Skip to content

fix(utils): use inner_text() in rate limit detection #278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
stickerdaniel wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(utils): use inner_text() in rate limit detection #278

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion linkedin_scraper/core/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ async def detect_rate_limit(page: Page) -> None:

# Check for rate limit messages
try:
body_text = await page.locator('body').text_content(timeout=1000)
body_text = await page.locator('body').inner_text(timeout=1000)
Comment on lines 89 to +91
Copy link

Copilot AI Feb 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There’s currently no automated test coverage for detect_rate_limit() (no tests reference it), and this change tweaks detection semantics in a way that’s easy to regress. Consider adding a small unit test using page.set_content() with hidden DOM text containing "try again later" to ensure it does not raise, and another with visible text to ensure it does raise.

Copilot uses AI. Check for mistakes.
if body_text:
body_lower = body_text.lower()
if any(phrase in body_lower for phrase in [
Expand Down
Loading