fix: update CompanyScraper selectors for new LinkedIn DOM#271
Open
choru-k wants to merge 1 commit intojoeyism:masterfrom
Open
fix: update CompanyScraper selectors for new LinkedIn DOM#271choru-k wants to merge 1 commit intojoeyism:masterfrom
choru-k wants to merge 1 commit intojoeyism:masterfrom
Conversation
- Navigate to /about page for detailed company info - Update CSS selectors for about section and overview details - Add multi-language support for field detection (English, Korean, Japanese) - Refactor overview extraction into helper methods - Add _parse_dl_definition_list() for dl.overflow-hidden dt/dd structure - Add _parse_top_card_info() for .org-top-card-summary-info-list - Add _find_website_link() for website URL extraction Fixes joeyism#238
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
LinkedIn changed their company page DOM structure, causing
CompanyScraperto return null for all fields exceptlinkedin_urlandname. This PR updates the selectors to match the new structure.Changes:
/aboutpage for more detailed company infosection.org-about-module__margin-bottom p.break-words)_parse_dl_definition_list()- Parsesdl.overflow-hidden dt/ddstructure_parse_top_card_info()- Parses.org-top-card-summary-info-list__info-item_find_website_link()- Extracts company website URLTest Results
Tested with multiple companies:
Backwards Compatibility
The changes maintain backwards compatibility:
dt/ddselectors as fallback.org-top-card-summary-info-list__info-itemif the new structure isn't foundCompanyobject structureFixes #238