fix: update filter behavior to clear tags when 'all' is selected#271
fix: update filter behavior to clear tags when 'all' is selected#271shubham6822 wants to merge 1 commit intojnsahaj:mainfrom
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThe pull request fixes UI state synchronization in the community theme filtering system. The sidebar now conditionally applies the "active" visual state only when no tags are selected, and clicking "All Themes" clears active tag filters from the URL query parameters. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@shubham6822 is attempting to deploy a commit to the Vercel Team on Vercel. A member of the Team first needs to authorize it. |
|
Hey @jnsahaj , |
What
?tags=query param from the URL, resetting the page to show all themesWhy
When a tag was active (e.g.,
?tags=minimal), the sidebar incorrectly highlighted both the tag and "All Themes" simultaneously. Additionally, clicking "All Themes" only updated thefilterstate but left thetagsparam intact, so themes remained filtered.Changes
app/community/components/community-sidebar.tsx: Updated active state logic for "All Themes" to only apply when no tags are selectedapp/community/components/community-themes-content.tsx: UpdatedhandleFilterChangeto callsetTags([])when"all"is selectedCloses #270
Summary by CodeRabbit