Open
Conversation
Pull Request Test Coverage Report for Build 8859155396Details
💛 - Coveralls |
GNU `getcwd` can allocate a buffer if passed `NULL` for it. This is an
extension which is e.g., not recognized by clang-tidy-19's
`StdCLibraryFunctions` check[^1] which emits a diagnostic on a violated
precondition `buf != NULL`,
```
The 1st argument to 'getcwd' is NULL but should not be NULL [clang-analyzer-unix.StdCLibraryFunctions,-warnings-as-errors]
[build] 3987 | std::unique_ptr<char, decltype(&std::free)> buffer{::getcwd(NULL, 0), std::free};
```
This patch modifies this use of `getcwd` with this extension behavior to
instead use `get_current_dir_name` which is also a GNU extension, but
does not trigger this diagnostic.
[^1]: https://clang.llvm.org/docs/analyzer/checkers.html#unix-stdclibraryfunctions-c
centos7 has reached EOL on 2024-06-30, centos8 on 2021-10-31. In practical terms this means that their package repositories are offline for the foreseeable future and the CI tasks making use of them might never run again. This patch replaces the existing CI jobs on centos7/centos8 with jobs on rockylinux8/9. Since rockylinux is an open source variant similar to RHEL this should provide testing with similar spirit. In contrast to centos, rockylinux does provide very granular tagging of releases which if used would help avoid breaking on e.g., subtle package changes in their package repositories. I however did not use very precise tags in the patch and instead went with broad "trains" for the 8 and 9 series; I hope this minimizes maintenance overhead (e.g., bumping to new releases) while still giving a good testing signal.
This resolves warnings when compiling with -wundef (and errors when combined with -werror).
Check macros are defined before use
…-buf Avoid GNU `getcwd` extension behavior
- read(): POSIX specifies that errno is undefined when read() return values are >= 0. The previous retry logic had bugs: When read() returns 0 (EOF), the loop condition checked errno before the return value. Since errno might be stale from a previous call, this could trigger a false retry on EOF. - readdir(): When readdir() reaches the end of directory, it returns NULL without modifying errno. Setting errno=0 before the loop caused an infinite loop.
…age steps, and add optional Docker setup
… image to 14.3 in Cirrus CI
…and fix EOL dependency issues
…orkaround for GCC 5-6, ensuring unified CMake configuration across all versions.
CI/workflow upgrade
Fix EINTR handling in read() and readdir() loops
Added MSYS2 compilers to GitHub workflow
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )