fix: compute padding correctly for MAX_LENGTH (0xffff) content#35
Merged
jmjoy merged 1 commit intojmjoy:masterfrom Apr 15, 2026
Merged
fix: compute padding correctly for MAX_LENGTH (0xffff) content#35jmjoy merged 1 commit intojmjoy:masterfrom
jmjoy merged 1 commit intojmjoy:masterfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes FastCGI Header padding computation for large content_length values by avoiding signed negation overflow and using wrapping unsigned arithmetic, ensuring correct padding across the full u16 range up to MAX_LENGTH (0xffff).
Changes:
- Replace
i16-based negation withu16::wrapping_subto computepadding_lengthsafely for allcontent_lengthvalues.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous padding calculation used signed negation via i16, which could overflow for large content lengths. Switch to wrapping unsigned arithmetic so padding is computed correctly across the full u16 range, including 0xffff (MAX_LENGTH)
This can be reproduced in debug builds with large content lengths, resulting in: