Make webcamjs more node-friendly#155
Open
sjdemartini wants to merge 2 commits intojhuckaby:masterfrom
Open
Conversation
This allows the module to be imported on the server, since it can be exported without requiring the `window`. The init() call that used to happen before exporting the module now happens automatically when attaching a webcam viewer for the first time.
Owner
|
Thanks man! I'll look this over as soon as I have some time. |
|
Traditionally, node is headless. What is the goal here? Electron support? Or more general support for modules? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The primary change here is to not initialize with an explicit
windowdependency.This allows the module to be imported on the server, since it can be exported without requiring the
window. Theinit()call that used to happen before exporting the module now happens automatically when attaching a webcam viewer for the first time.This solution is not as heavy-handed as #66, in that this does not allow for separate
Webcaminstances (e.g., does not allow for multiple independentWebcampreviews to have separateflashNotifycallbacks), but does improve modularization. Ultimately, that approach is probably preferred, but these changes will allow for at least this simple implementation to work in anodeenvironment.