[12.1.x] Fixes #14870 - Refactor compliance checks.#14871
Open
sbordet wants to merge 1 commit intojetty-12.1.xfrom
Open
[12.1.x] Fixes #14870 - Refactor compliance checks.#14871sbordet wants to merge 1 commit intojetty-12.1.xfrom
sbordet wants to merge 1 commit intojetty-12.1.xfrom
Conversation
Contributor
|
There's a few scenarios that need to be solved. |
lorban
requested changes
Apr 17, 2026
Contributor
lorban
left a comment
There was a problem hiding this comment.
Looks alright, but break a lot of tests
* Refactored compliance checks that are common across all HTTP versions to common code. * Fixed HttpClient to send a Host header matching the authority-form in case of CONNECT requests. * Fixed tests that incorrectly sent the Host header different from the authority-form in CONNECT requests. Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
1399e22 to
a2f0d5a
Compare
joakime
approved these changes
Apr 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactored compliance checks that are common across all HTTP versions to common code.