fix: Wait for service request message response#250
Open
galorithm wants to merge 1 commit intojenkinsci:mainfrom
Open
fix: Wait for service request message response#250galorithm wants to merge 1 commit intojenkinsci:mainfrom
galorithm wants to merge 1 commit intojenkinsci:mainfrom
Conversation
Prior to this commit, the authentication code sent 'ssh-userauth' SSH_MSG_SERVICE_REQUEST followed by 'ssh-connection' SSH_MSG_USERAUTH_REQUEST before waiting for responses of both of these requests. This is a violation of the protocol which mentions (quoting the protocol RFC 4253 Section 8 "Service Request"): "Note that after a key exchange with implicit server authentication, the client MUST wait for response to its service request message before sending any further data." This commit changes the code to wait for SSH_MSG_SERVICE_REQUEST response before sending the SSH_MSG_USERAUTH_REQUEST to adhere to the protocol. Signed-off-by: Eshan Kelkar <eshankelkar@galorithm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prior to this PR, the authentication code sent 'ssh-userauth' SSH_MSG_SERVICE_REQUEST followed by 'ssh-connection' SSH_MSG_USERAUTH_REQUEST before waiting for responses of both of these requests.
This seems to be a violation of the protocol which mentions (quoting the protocol RFC 4253 Section 8 "Service Request"):
"Note that after a key exchange with implicit server authentication, the client MUST wait for response to its service request message before sending any further data."
This pull request changes the code to wait for SSH_MSG_SERVICE_REQUEST response before sending the SSH_MSG_USERAUTH_REQUEST to adhere to the protocol.
See https://gitlab.com/libssh/libssh-mirror/-/issues/311
See JENKINS-75919.
(Not adding any explicit tests, since I assume regression tests for ssh client would already be present ? Please correct me if they aren't)
Submitter checklist