Conversation
allxiao
force-pushed
the
it
branch
6 times, most recently
from
28053b7 to
09fb03b
Compare
| export KUBERNETES_CD_DOCKER_PASSWORD="$(az acr credential show --name "$acr_name" --query "passwords[0].value" --output tsv)" | ||
| export KUBERNETES_CD_DOCKER_REGISTRY="http://$KUBERNETES_CD_DOCKER_REPOSITORY" | ||
|
|
||
| docker pull nginx |
There was a problem hiding this comment.
This should be called even if KUBERNETES_CD_DOCKER_REPOSITORY is empty?
There was a problem hiding this comment.
The intention here is:
- if we test against existing docker repository, we pass in all the details of the repo and then we skip the repository setup
- otherwise if
KUBERNETES_CD_DOCKER_REPOSITORYis empty, we setup new ACR instance and prepare the image for testing
| bash src/test/java/com/microsoft/jenkins/kubernetes/integration/integration-test.sh | ||
|
|
||
| Prerequisites: | ||
| * Logged in Azure CLI |
There was a problem hiding this comment.
Since this plugin is a general k8s plugin, provide an option that user can run the test without Azure (suppose they have already have a k8s cluster)?
There was a problem hiding this comment.
If the user pass in all the details, we will skip the Azure ACS & ACR setup. We have a check to ensure that
resource_group=
if [[ -z "$KUBERNETES_CD_MASTER_HOST" ]] || [[ -z "$KUBERNETES_CD_DOCKER_REPOSITORY" ]]; then
resource_group="k8s-test-$suffix"
fiHowever, currently the check for az account happens too early. It is not necessary if user do not need to provision Azure resources. I will update the code logic and the documentation.
| import java.io.OutputStream; | ||
| import java.util.UUID; | ||
|
|
||
| public class TestHelpers { |
There was a problem hiding this comment.
Move some common methods to common plugin so that they can be reused?
There was a problem hiding this comment.
make sense. I will copy the logic to commons and when that's available in new commons release, we can remove the duplicates in the descendants.
|
Why not merge this PR? @ArieShout |
3 participants
No description provided.