Skip to content

refactor: enable codeql alerts#197

Open
osamamagdy wants to merge 2 commits intojenkins-x:masterfrom
osamamagdy:patch-1
Open

refactor: enable codeql alerts#197
osamamagdy wants to merge 2 commits intojenkins-x:masterfrom
osamamagdy:patch-1

Conversation

@osamamagdy
Copy link
Copy Markdown
Member

@jenkins-x-bot
Copy link
Copy Markdown
Contributor

Hi @osamamagdy. Thanks for your PR.

I'm waiting for a jenkins-x or todo member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository.

@jenkins-x-bot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign jstrachan
You can assign the PR to them by writing /assign @jstrachan in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ankitm123
Copy link
Copy Markdown
Member

Can you remove the resource requests:

See jx-pipeline for an example.

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented May 4, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@osamamagdy
Copy link
Copy Markdown
Member Author

Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants