fix(mrml-core): resolve mj-include inside mj-attributes#632
Merged
Conversation
Closes #501 Signed-off-by: Jeremie Drouet <jeremie.drouet@gmail.com>
Contributor
|
📈 This is how your metrics evolved 📉 |
Merged
jdrouet
pushed a commit
that referenced
this pull request
Apr 12, 2026
## 🤖 New release
* `mrml`: 5.1.0 -> 6.0.0 (⚠ API breaking changes)
* `mrml-cli`: 1.7.1 -> 1.7.2
* `mrml-python`: 0.2.1 -> 0.2.2
* `mrml-wasm`: 1.5.1 -> 1.6.0
### ⚠ `mrml` breaking changes
```text
--- failure auto_trait_impl_removed: auto trait no longer implemented ---
Description:
A public type has stopped implementing one or more auto traits. This can break downstream code that depends on the traits being implemented.
ref: https://doc.rust-lang.org/reference/special-types-and-traits.html#auto-traits
impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.46.0/src/lints/auto_trait_impl_removed.ron
Failed in:
type Error is no longer UnwindSafe, in /tmp/.tmpb24T4I/mrml/packages/mrml-core/src/prelude/render/mod.rs:18
type Error is no longer RefUnwindSafe, in /tmp/.tmpb24T4I/mrml/packages/mrml-core/src/prelude/render/mod.rs:18
--- failure enum_variant_added: enum variant added on exhaustive enum ---
Description:
A publicly-visible enum without #[non_exhaustive] has a new variant.
ref: https://doc.rust-lang.org/cargo/reference/semver.html#enum-variant-new
impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.46.0/src/lints/enum_variant_added.ron
Failed in:
variant WarningKind:InlineStyleUnsupported in /tmp/.tmpb24T4I/mrml/packages/mrml-core/src/prelude/parser/output.rs:9
variant Error:InlineCSS in /tmp/.tmpb24T4I/mrml/packages/mrml-core/src/prelude/render/mod.rs:25
--- failure inherent_method_missing: pub method removed or renamed ---
Description:
A publicly-visible method or associated fn is no longer available under its prior name. It may have been renamed or removed entirely.
ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove
impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.46.0/src/lints/inherent_method_missing.ron
Failed in:
Component::is_inline, previously in file /tmp/.tmpjWoKrE/mrml/src/mj_style/mod.rs:32
```
<details><summary><i><b>Changelog</b></i></summary><p>
## `mrml`
<blockquote>
##
[6.0.0](mrml-v5.1.0...mrml-v6.0.0)
- 2026-04-12
### Added
- add CSS inlining support for mj-style with inline attribute
([#537](#537))
### Fixed
- *(mrml-core)* allow mj-include directly inside mjml
([#633](#633))
- *(mrml-core)* resolve mj-include inside mj-attributes
([#632](#632))
- mj-include with multiple roots
([#631](#631))
- *(mrml-core)* propagate section inner width to column children
([#630](#630))
- *(mrml-core)* propagate container width to mj-hero children
([#629](#629))
- *(mrml-core)* multiply pixel-to-percent mobile width by 100
([#628](#628))
- twitter share url ([#624](#624))
- vml mso width style ([#623](#623))
- *(mrml-core)* preserve VML namespace prefixes in parsed elements
([#622](#622))
### Other
- *(deps)* update Rust dependencies
([#625](#625))
- update html resources
([#621](#621))
- fix `result.startswith` in Python usage demo
([#589](#589))
- improve readme wording
([#571](#571))
</blockquote>
## `mrml-cli`
<blockquote>
##
[1.7.2](mrml-cli-v1.7.1...mrml-cli-v1.7.2)
- 2026-04-12
### Other
- update Cargo.lock dependencies
</blockquote>
## `mrml-python`
<blockquote>
##
[0.2.2](mrml-python-v0.2.1...mrml-python-v0.2.2)
- 2026-04-12
### Added
- add CSS inlining support for mj-style with inline attribute
([#537](#537))
### Fixed
- fix python package to build with python 3.14
([#596](#596))
### Other
- *(deps)* update Rust dependencies
([#625](#625))
</blockquote>
## `mrml-wasm`
<blockquote>
##
[1.6.0](mrml-wasm-v1.5.1...mrml-wasm-v1.6.0)
- 2026-04-12
### Added
- add CSS inlining support for mj-style with inline attribute
([#537](#537))
### Fixed
- *(mrml-core)* multiply pixel-to-percent mobile width by 100
([#628](#628))
### Other
- update js deps ([#626](#626))
- update html resources
([#621](#621))
</blockquote>
</p></details>
---
This PR was generated with
[release-plz](https://github.com/release-plz/release-plz/).
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #501